]> asedeno.scripts.mit.edu Git - linux.git/commit
thermal_hwmon: Sanitize attribute name passed to hwmon
authorMarc Zyngier <marc.zyngier@arm.com>
Tue, 10 Jul 2018 15:40:34 +0000 (16:40 +0100)
committerEduardo Valentin <edubezval@gmail.com>
Fri, 27 Jul 2018 21:43:20 +0000 (14:43 -0700)
commit409ef0bacacf72c51cc876349ae3fdf7cf726d47
tree49d30701f15e27b6f32392fbe34565bb1702c77c
parent59d7f4a7fa9821a4ce0ea5870c367f9d8adb2619
thermal_hwmon: Sanitize attribute name passed to hwmon

My Chromebook Plus (kevin) is spitting the following at boot time:

(NULL device *): hwmon: 'sbs-9-000b' is not a valid name attribute, please fix

Clearly, __hwmon_device_register is unhappy about the property name.
Some investigation reveals that thermal_add_hwmon_sysfs doesn't
sanitize the name of the attribute.

In order to keep it quiet, let's replace '-' with '_' in hwmon->type
This is consistent with what iio-hwmon does since b92fe9e3379c8.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/thermal_hwmon.c