]> asedeno.scripts.mit.edu Git - linux.git/commit
netlink: Make groups check less stupid in netlink_bind()
authorDmitry Safonov <dima@arista.com>
Mon, 3 Sep 2018 21:40:51 +0000 (22:40 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Sep 2018 05:11:33 +0000 (22:11 -0700)
commit428f944bd58607021b5a1f85d145c0b50f908c6f
tree9eb7a6c61b82a4a901ab728317ce3cf39fbcbd6b
parentfa788d986a3aac5069378ed04697bd06f83d3488
netlink: Make groups check less stupid in netlink_bind()

As Linus noted, the test for 0 is needless, groups type can follow the
usual kernel style and 8*sizeof(unsigned long) is BITS_PER_LONG:

> The code [..] isn't technically incorrect...
> But it is stupid.
> Why stupid? Because the test for 0 is pointless.
>
> Just doing
>        if (nlk->ngroups < 8*sizeof(groups))
>                groups &= (1UL << nlk->ngroups) - 1;
>
> would have been fine and more understandable, since the "mask by shift
> count" already does the right thing for a ngroups value of 0. Now that
> test for zero makes me go "what's special about zero?". It turns out
> that the answer to that is "nothing".
[..]
> The type of "groups" is kind of silly too.
>
> Yeah, "long unsigned int" isn't _technically_ wrong. But we normally
> call that type "unsigned long".

Cleanup my piece of pointlessness.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: netdev@vger.kernel.org
Fairly-blamed-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c