]> asedeno.scripts.mit.edu Git - linux.git/commit
usb: gadget: udc: lpc32xx: fix return value check in lpc32xx_udc_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Sat, 4 May 2019 07:04:07 +0000 (07:04 +0000)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Thu, 6 Jun 2019 10:51:57 +0000 (13:51 +0300)
commit42cc68868ce9d5f5277f561bb17b4746a332bb28
tree5966ef7f933145b039929f0482b1a640d1d56911
parent066cfd0770aba8a9ac79b59d99530653885d919d
usb: gadget: udc: lpc32xx: fix return value check in lpc32xx_udc_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

This issue was detected by using the Coccinelle software.

Fixes: 408b56ca5c8e ("usb: gadget: udc: lpc32xx: simplify probe")
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/lpc32xx_udc.c