]> asedeno.scripts.mit.edu Git - linux.git/commit
pinctrl: samsung: fix leaked of_node references
authorWen Yang <wen.yang99@zte.com.cn>
Fri, 12 Apr 2019 06:02:22 +0000 (14:02 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 23 Apr 2019 08:59:47 +0000 (10:59 +0200)
commit44b9f86cd41db6c522effa5aec251d664a52fbc0
treeb73d5474ade6a31d7d49fbe1411ed3066a998c27
parenta7672c4a3f2957bccc61b126dfc571a41c32aaf0
pinctrl: samsung: fix leaked of_node references

The call to of_find_compatible_node returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./drivers/pinctrl/samsung/pinctrl-exynos-arm.c:76:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
./drivers/pinctrl/samsung/pinctrl-exynos-arm.c:82:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/samsung/pinctrl-exynos-arm.c