]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: dapm: fix a memory leak bug
authorWenwen Wang <wenwen@cs.uga.edu>
Mon, 22 Jul 2019 13:57:44 +0000 (08:57 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jul 2019 16:33:38 +0000 (17:33 +0100)
commit45004d66f2a28d78f543fb2ffbc133e31dc2d162
treeca55e1411f9c37fe844588b04d9d90e114109edc
parent62ec3d13601bd626ca7a0edef6d45dbb753d94e8
ASoC: dapm: fix a memory leak bug

In snd_soc_dapm_new_control_unlocked(), a kernel buffer is allocated in
dapm_cnew_widget() to hold the new dapm widget. Then, different actions are
taken according to the id of the widget, i.e., 'w->id'. If any failure
occurs during this process, snd_soc_dapm_new_control_unlocked() should be
terminated by going to the 'request_failed' label. However, the allocated
kernel buffer is not freed on this code path, leading to a memory leak bug.

To fix the above issue, free the buffer before returning from
snd_soc_dapm_new_control_unlocked() through the 'request_failed' label.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Link: https://lore.kernel.org/r/1563803864-2809-1-git-send-email-wang6495@umn.edu
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c