]> asedeno.scripts.mit.edu Git - linux.git/commit
btrfs: sysfs: Fix error path kobject memory leak
authorTobin C. Harding <tobin@kernel.org>
Mon, 13 May 2019 03:39:11 +0000 (13:39 +1000)
committerDavid Sterba <dsterba@suse.com>
Thu, 16 May 2019 12:31:01 +0000 (14:31 +0200)
commit450ff8348808a89cc27436771aa05c2b90c0eef1
treef3b1626d7b2620b987f9d0f2f06783fdf228466b
parent72bd2323ec87722c115a5906bc6a1b31d11e8f54
btrfs: sysfs: Fix error path kobject memory leak

If a call to kobject_init_and_add() fails we must call kobject_put()
otherwise we leak memory.

Calling kobject_put() when kobject_init_and_add() fails drops the
refcount back to 0 and calls the ktype release method (which in turn
calls the percpu destroy and kfree).

Add call to kobject_put() in the error path of call to
kobject_init_and_add().

Cc: stable@vger.kernel.org # v4.4+
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tobin C. Harding <tobin@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent-tree.c