]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/tilcdc: Use drm_fbdev_generic_setup()
authorNoralf Trønnes <noralf@tronnes.org>
Thu, 25 Oct 2018 20:13:39 +0000 (22:13 +0200)
committerNoralf Trønnes <noralf@tronnes.org>
Thu, 1 Nov 2018 14:25:41 +0000 (15:25 +0100)
commit45cf87566e5686c919247610200af7b365e86a1f
tree8ba55cc0cfc1c6f576d31ddf1f9f54f7fd5d13c0
parent94ebfc07829187bc7ec8fc3f1133a202aecec283
drm/tilcdc: Use drm_fbdev_generic_setup()

The CMA helper is already using the drm_fb_helper_generic_probe part of
the generic fbdev emulation. This patch makes full use of the generic
fbdev emulation by using its drm_client callbacks. This means that
drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
now handled by the emulation code. Additionally fbdev unregister happens
automatically on drm_dev_unregister().

The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
driver. This is done to highlight the fact that fbdev emulation is an
internal client that makes use of the driver, it is not part of the
driver as such. If fbdev setup fails, an error is printed, but the driver
succeeds probing.

Cc: Jyri Sarha <jsarha@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Jyri Sarha <jsarha@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181025201340.34227-9-noralf@tronnes.org
drivers/gpu/drm/tilcdc/tilcdc_drv.c