]> asedeno.scripts.mit.edu Git - linux.git/commit
skd: Make it easier for static analyzers to analyze skd_free_disk()
authorBart Van Assche <bart.vanassche@wdc.com>
Fri, 25 Aug 2017 21:24:13 +0000 (14:24 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 25 Aug 2017 21:29:43 +0000 (15:29 -0600)
commit4633504c1a3a452ff03a5dbe50beb082fa1bfac6
tree0e5e1295152df28a13ecb8a9f4ee1b9518ac20a7
parent795bc1b54265ec532d09960762bd3d58d1a63c8f
skd: Make it easier for static analyzers to analyze skd_free_disk()

Although it is easy to see that skdev->disk != NULL if skdev->queue
!= NULL, add a test for skdev->disk to avoid that smatch reports the
following warning:

drivers/block/skd_main.c:3080 skd_free_disk()
         error: we previously assumed 'disk' could be null (see line 3074)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/skd_main.c