]> asedeno.scripts.mit.edu Git - linux.git/commit
perf tools: Avoid double free in read_event_file()
authorSanskriti Sharma <sansharm@redhat.com>
Tue, 2 Oct 2018 14:29:13 +0000 (10:29 -0400)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 8 Oct 2018 17:23:46 +0000 (14:23 -0300)
commit470c8f7c88de013d266e1b61044efe8937728b7f
tree2024fe6a048c02880d7b7eb058698ae202f22d7a
parent9c8a182e5a73e01afd11742a2ab887bf338fdafd
perf tools: Avoid double free in read_event_file()

The temporary 'buf' buffer allocated in read_event_file() may be freed
twice.  Move the free() call to the common function exit point.

Fixes the following coverity complaints:

  Error: USE_AFTER_FREE (CWE-825):
  tools/perf/util/trace-event-read.c:309: double_free: Calling "free"
  frees pointer "buf" which has already been freed.

Signed-off-by: Sanskriti Sharma <sansharm@redhat.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-5-git-send-email-sansharm@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/trace-event-read.c