]> asedeno.scripts.mit.edu Git - linux.git/commit
net: phy: bcm87xx: improve bcm87xx_config_init and feature detection
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 24 May 2019 20:24:19 +0000 (22:24 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 May 2019 04:56:41 +0000 (21:56 -0700)
commit476cc6c964a92a67aeec1597d6d40f5bbbdf1b03
treec3d313e719ddea2897fa3e3776ca6f9a38429cfb
parent8fb91c3550c4666d4c37b5494b1c68aa9c3284a5
net: phy: bcm87xx: improve bcm87xx_config_init and feature detection

PHY drivers don't have to and shouldn't fiddle with phylib internals.
Most of the code in bcm87xx_config_init() can be removed because
phylib takes care.

In addition I replaced usage of PHY_10GBIT_FEC_FEATURES with an
implementation of the get_features callback. PHY_10GBIT_FEC_FEATURES
is used by this driver only and it's questionable whether there
will be any other PHY supporting this mode only. Having said that
in one of the next kernel versions we may decide to remove it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/bcm87xx.c