]> asedeno.scripts.mit.edu Git - linux.git/commit
bluetooth: bpa10x: Replace GFP_ATOMIC with GFP_KERNEL in bpa10x_send_frame()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 23 Jul 2018 03:24:02 +0000 (11:24 +0800)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 23 Jul 2018 16:05:00 +0000 (18:05 +0200)
commit478113e43162e409bbc6d79e87c2301728f26db2
treec071e6ad22f0aa82f8e9de7ad1cd96a089e8c144
parent5f9c6580f6324e279417fc66e80ade0c42bfa9d9
bluetooth: bpa10x: Replace GFP_ATOMIC with GFP_KERNEL in bpa10x_send_frame()

bpa10x_send_frame() is only set to hdev->send, and hdev->send() is never
called in atomic context.

bpa10x_send_frame() calls usb_alloc_urb(), kmalloc() and usb_submit_urb()
with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/bpa10x.c