]> asedeno.scripts.mit.edu Git - linux.git/commit
crypto: atmel-tdes - remove unnecessary static in atmel_tdes_remove()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 18 Jul 2017 23:05:50 +0000 (18:05 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 3 Aug 2017 05:47:18 +0000 (13:47 +0800)
commit47f1241ec320302edb77d117302b1990178b449b
treef99327543cc77c380491e2c4c4c16f9deceacdad
parent22d96f04bb7498549ae7c130f03d7ea327744c5a
crypto: atmel-tdes - remove unnecessary static in atmel_tdes_remove()

Remove unnecessary static on local variable tdes_dd. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object
file size. This log is the output of the size command, before and after
the code change:

before:
   text    data     bss     dec     hex filename
  17079    8704     128   25911    6537 drivers/crypto/atmel-tdes.o

after:
   text    data     bss     dec     hex filename
  17039    8616      64   25719    6477 drivers/crypto/atmel-tdes.o

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/atmel-tdes.c