]> asedeno.scripts.mit.edu Git - linux.git/commit
clk: imx: fix potential NULL dereference in imx8qxp_lpcg_clk_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 18 Dec 2018 06:43:09 +0000 (06:43 +0000)
committerStephen Boyd <sboyd@kernel.org>
Wed, 9 Jan 2019 18:34:54 +0000 (10:34 -0800)
commit48504619a65977fb2a4c7182eab637867f1e6548
treeb26d65a50a3b6f5924cde2482ab1cb3694b95a90
parentbfeffd155283772bbe78c6a05dec7c0128ee500c
clk: imx: fix potential NULL dereference in imx8qxp_lpcg_clk_probe()

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Fixes: 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/imx/clk-imx8qxp-lpcg.c