]> asedeno.scripts.mit.edu Git - linux.git/commit
media: cec: forgot to cancel delayed work
authorHans Verkuil <hverkuil@xs4all.nl>
Mon, 15 Oct 2018 10:14:22 +0000 (06:14 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 15 Oct 2018 13:57:52 +0000 (09:57 -0400)
commit490d84f6d73c12f4204241cff8651eed60aae914
tree2e90dfab1ce66bd12cfaab752d15eb0dbf311de8
parent8caec72e8cbff65afa38928197bea5a393b67975
media: cec: forgot to cancel delayed work

If the wait for completion was interrupted, then make sure to cancel
any delayed work.

This can only happen if a transmit is waiting for a reply, and you press
Ctrl-C or reboot/poweroff or something like that which interrupts the
thread waiting for the reply and then proceeds to delete the CEC message.

Since the delayed work wasn't canceled, once it would trigger it referred
to stale data and resulted in a kernel oops.

Fixes: 7ec2b3b941a6 ("cec: add new tx/rx status bits to detect aborts/timeouts")
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Cc: <stable@vger.kernel.org> # for v4.18 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/cec/cec-adap.c