]> asedeno.scripts.mit.edu Git - linux.git/commit
xfs: xfs_reflink_convert_cow() memory allocation deadlock
authorDave Chinner <dchinner@redhat.com>
Thu, 7 Jun 2018 14:46:42 +0000 (07:46 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 8 Jun 2018 17:07:51 +0000 (10:07 -0700)
commit4a2d01b076d231afebbea04647373644e767b453
treecbc2479bf4ca80dc56e6b67beb77a28d3415eae0
parentef215e394eeb960ea0e8a0fd37ba2fa30260e05b
xfs: xfs_reflink_convert_cow() memory allocation deadlock

xfs_reflink_convert_cow() manipulates the incore extent list
in GFP_KERNEL context in the IO submission path whilst holding
locked pages under writeback. This is a memory reclaim deadlock
vector. This code is not in a transaction, so any memory allocations
it makes aren't protected via the memalloc_nofs_save() context that
transactions carry.

Hence we need to run this call under memalloc_nofs_save() context to
prevent potential memory allocations from being run as GFP_KERNEL
and deadlocking.

Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_aops.c
fs/xfs/xfs_buf.c
fs/xfs/xfs_linux.h