]> asedeno.scripts.mit.edu Git - linux.git/commit
opp: cpu: Replace GFP_ATOMIC with GFP_KERNEL in dev_pm_opp_init_cpufreq_table
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 26 Jan 2018 08:48:49 +0000 (16:48 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 12 Feb 2018 09:37:46 +0000 (15:07 +0530)
commit4a823c0be80fa996234ebb41c80d40458b1bec1e
tree114225c53980159bfb8c69957983bf5ad31dd8d7
parent7928b2cbe55b2a410a0f5c1f154610059c57b1b2
opp: cpu: Replace GFP_ATOMIC with GFP_KERNEL in dev_pm_opp_init_cpufreq_table

After checking all possible call chains to
dev_pm_opp_init_cpufreq_table() here,
my tool finds that this function is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
And dev_pm_opp_init_cpufreq_table() calls dev_pm_opp_get_opp_count(),
which calls mutex_lock that can sleep.
It indicates that atmtcp_v_send() can call functions which may sleep.
Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/cpu.c