]> asedeno.scripts.mit.edu Git - linux.git/commit
gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd
authorAndrew Price <anprice@redhat.com>
Mon, 8 Oct 2018 12:52:43 +0000 (07:52 -0500)
committerBob Peterson <rpeterso@redhat.com>
Mon, 8 Oct 2018 12:52:43 +0000 (07:52 -0500)
commit4c62bd9cea7bcf10292f7e4c57a2bca332942697
tree4f25341b2191bf08d1d0182e75cbdc50732fb0c7
parente54c78a27fcdef406af799f360a93e6754adeefe
gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd

When alloc_percpu() fails, sdp gets freed but sb->s_fs_info still points
to the same address. Move the assignment after that error check so that
s_fs_info can only point to a valid sdp or NULL, which is checked for
later in the error path, in gfs2_kill_super().

Reported-by: syzbot+dcb8b3587445007f5808@syzkaller.appspotmail.com
Signed-off-by: Andrew Price <anprice@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/ops_fstype.c