]> asedeno.scripts.mit.edu Git - PuTTY.git/commit
In SOCKS5 dynamic forwarding, we were echoing back DST.{ADDR,PORT} as
authorJacob Nevins <jacobn@chiark.greenend.org.uk>
Fri, 10 Oct 2003 21:20:01 +0000 (21:20 +0000)
committerJacob Nevins <jacobn@chiark.greenend.org.uk>
Fri, 10 Oct 2003 21:20:01 +0000 (21:20 +0000)
commit4de860abcfe4165f3df62c2aaa75f5717a29096a
tree31521abbef82dc85707e695157aa30188d088c1b
parentc8a6df1e1c3a6ff62863a76d15cea6fa217a4fdd
In SOCKS5 dynamic forwarding, we were echoing back DST.{ADDR,PORT} as
BND.{ADDR,PORT}. Besides being clearly wrong, correspondence with
Sascha Schwarz suggests that this can confuse some SOCKS5 clients
(Aventail and sockscap32) which seem to assume that the reply must
have ATYP=1 (IPv4 literal) and so get the length wrong.

Now all replies have ATYP=1 with BND.{ADDR,PORT} = 0.0.0.0:0 -- this
apparently follows practice in OpenSSH. (We don't have enough info to
fill these fields in correctly.)

[originally from svn r3496]
portfwd.c