]> asedeno.scripts.mit.edu Git - linux.git/commit
ext4: bugfix for mmaped pages in mpage_release_unused_pages()
authorwangguang <wang.guang55@zte.com.cn>
Thu, 15 Sep 2016 15:32:46 +0000 (11:32 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 15 Sep 2016 15:32:46 +0000 (11:32 -0400)
commit4e800c0359d9a53e6bf0ab216954971b2515247f
tree4f3db0d503f941d80cc55810da3954400575a274
parente22834f0248d0fa841ead6436d6c19f65539dc9c
ext4: bugfix for mmaped pages in mpage_release_unused_pages()

Pages clear buffers after ext4 delayed block allocation failed,
However, it does not clean its pte_dirty flag.
if the pages unmap ,in cording to the pte_dirty ,
unmap_page_range may try to call __set_page_dirty,

which may lead to the bugon at
mpage_prepare_extent_to_map:head = page_buffers(page);.

This patch just call clear_page_dirty_for_io to clean pte_dirty
at mpage_release_unused_pages for pages mmaped.

Steps to reproduce the bug:

(1) mmap a file in ext4
addr = (char *)mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_SHARED,
                    fd, 0);
memset(addr, 'i', 4096);

(2) return EIO at

ext4_writepages->mpage_map_and_submit_extent->mpage_map_one_extent

which causes this log message to be print:

                ext4_msg(sb, KERN_CRIT,
                        "Delayed block allocation failed for "
                        "inode %lu at logical offset %llu with"
                        " max blocks %u with error %d",
                        inode->i_ino,
                        (unsigned long long)map->m_lblk,
                        (unsigned)map->m_len, -err);

(3)Unmap the addr cause warning at

__set_page_dirty:WARN_ON_ONCE(warn && !PageUptodate(page));

(4) wait for a minute,then bugon happen.

Cc: stable@vger.kernel.org
Signed-off-by: wangguang <wangguang03@zte.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c