]> asedeno.scripts.mit.edu Git - linux.git/commit
amd64_edac: Fix incorrect wraparounds
authorAravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Sat, 24 Aug 2013 15:47:48 +0000 (10:47 -0500)
committerBorislav Petkov <bp@suse.de>
Tue, 27 Aug 2013 13:00:22 +0000 (15:00 +0200)
commit4fc06b3171f4de92cd21bf7ab1cb0bf62f05769d
tree9f95e7ce272ba34b68d19c6fb42798e3c04c1863
parent3f0aba4fc0ec789634c29a8265b90b8b0d1a4e29
amd64_edac: Fix incorrect wraparounds

dct_base and dct_limit obtain 32 bit register values when they read
their respective pci config space registers. A left shift beyond 32 bits
will cause them to wrap around. Similar case for chan_addr as can be
seen from the bug report (link below). In the patch, we rectify this by
casting chan_addr to u64 and by comparing dct_base and dct_limit against
properly shifted sys_addr in order to compare the correct bits.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Link: http://lkml.kernel.org/r/20130819132302.GA12171@elgon.mountain
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/amd64_edac.c