]> asedeno.scripts.mit.edu Git - linux.git/commit
media: bt8xx: Remove unnecessary self-assignment
authorNathan Chancellor <natechancellor@gmail.com>
Sat, 15 Sep 2018 06:06:13 +0000 (02:06 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 24 Sep 2018 13:41:47 +0000 (09:41 -0400)
commit502fac1ef3498e345086e75ff2442fda88c57b6c
tree78c984d2941d55557ac8a106a4c2c6bf05dcbfe1
parentae5a8ca834f9dd0797a2ceb210e71d194431990c
media: bt8xx: Remove unnecessary self-assignment

Clang warns when a variable is assigned to itself.

drivers/media/pci/bt8xx/bttv-driver.c:2043:13: warning: explicitly
assigning value of variable of type '__s32' (aka 'int') to itself
[-Wself-assign]
        min_height = min_height;
        ~~~~~~~~~~ ^ ~~~~~~~~~~
1 warning generated.

There doesn't appear to be any good reason for this and this statement
was added in commit e5bd0260e7d3 ("V4L/DVB (5077): Bttv cropping
support") back in 2007. Just remove it.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/bt8xx/bttv-driver.c