]> asedeno.scripts.mit.edu Git - linux.git/commit
icmp: remove duplicate code
authorMatteo Croce <mcroce@redhat.com>
Sat, 2 Nov 2019 00:12:04 +0000 (01:12 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Nov 2019 22:03:11 +0000 (14:03 -0800)
commit54074f1dbd6fbc0f0a085a54f3297ae26e424d59
tree92febdbde61f84d4ff24efe5db7520126522be56
parent15122464d525f684a61806d28597050cdcef0f32
icmp: remove duplicate code

The same code which recognizes ICMP error packets is duplicated several
times. Use the icmp_is_err() and icmpv6_is_err() helpers instead, which
do the same thing.

ip_multipath_l3_keys() and tcf_nat_act() didn't check for all the error types,
assume that they should instead.

Signed-off-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/netfilter/nf_socket_ipv4.c
net/ipv4/route.c
net/ipv6/route.c
net/netfilter/nf_conntrack_proto_icmp.c
net/netfilter/xt_HMARK.c
net/sched/act_nat.c