]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: intel: skl: Fix possible buffer overflow in debug outputs
authorTakashi Iwai <tiwai@suse.de>
Tue, 18 Feb 2020 11:17:36 +0000 (12:17 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 19 Feb 2020 13:36:15 +0000 (13:36 +0000)
commit549cd0ba04dcfe340c349cd983bd440480fae8ee
tree0e66fe0cbc446d87e456917cfa950a523f593acf
parent64bbacc5f08c01954890981c63de744df1f29a30
ASoC: intel: skl: Fix possible buffer overflow in debug outputs

The debugfs output of intel skl driver writes strings with multiple
snprintf() calls with the fixed size.  This was supposed to avoid the
buffer overflow but actually it still would, because snprintf()
returns the expected size to be output, not the actual output size.

Fix it by replacing snprintf() calls with scnprintf().

Fixes: d14700a01f91 ("ASoC: Intel: Skylake: Debugfs facility to dump module config")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20200218111737.14193-3-tiwai@suse.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl-debug.c