]> asedeno.scripts.mit.edu Git - linux.git/commit
ipmi:ssif: compare block number correctly for multi-part return messages
authorKamlakant Patel <kamlakantp@marvell.com>
Wed, 24 Apr 2019 11:50:43 +0000 (11:50 +0000)
committerCorey Minyard <cminyard@mvista.com>
Wed, 24 Apr 2019 14:36:42 +0000 (09:36 -0500)
commit55be8658c7e2feb11a5b5b33ee031791dbd23a69
tree7789ee60196734f7a83d6b2e1238b41d81581ef9
parentd73236383eb1cd4b7b65c33a09f0ed45f6781f40
ipmi:ssif: compare block number correctly for multi-part return messages

According to ipmi spec, block number is a number that is incremented,
starting with 0, for each new block of message data returned using the
middle transaction.

Here, the 'blocknum' is data[0] which always starts from zero(0) and
'ssif_info->multi_pos' starts from 1.
So, we need to add +1 to blocknum while comparing with multi_pos.

Fixes: 7d6380cd40f79 ("ipmi:ssif: Fix handling of multi-part return messages").
Reported-by: Kiran Kolukuluru <kirank@ami.com>
Signed-off-by: Kamlakant Patel <kamlakantp@marvell.com>
Message-Id: <1556106615-18722-1-git-send-email-kamlakantp@marvell.com>
[Also added a debug log if the block numbers don't match.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: stable@vger.kernel.org # 4.4
drivers/char/ipmi/ipmi_ssif.c