]> asedeno.scripts.mit.edu Git - linux.git/commit
RDMA/core: Fix return code when modify_port isn't supported
authorKamal Heib <kamalheib1@gmail.com>
Mon, 28 Oct 2019 15:59:28 +0000 (17:59 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 6 Nov 2019 17:29:15 +0000 (13:29 -0400)
commit55bfe905fa97633438c13fb029aed85371d85480
treeae555a6d46e6c6bafc88c53f6ebd60bf9439c7e0
parentb4bc76609722f175a257184cc17ad73226d4b716
RDMA/core: Fix return code when modify_port isn't supported

Improve return code from ib_modify_port() by doing the following:
 - Use "-EOPNOTSUPP" instead "-ENOSYS" which is the proper return code

 - Allow only fake IB_PORT_CM_SUP manipulation for RoCE providers that
   didn't implement the modify_port callback, otherwise return
   "-EOPNOTSUPP"

Fixes: 61e0962d5221 ("IB: Avoid ib_modify_port() failure for RoCE devices")
Link: https://lore.kernel.org/r/20191028155931.1114-2-kamalheib1@gmail.com
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/device.c