]> asedeno.scripts.mit.edu Git - linux.git/commit
dmaengine: st_fdma: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 4 Jan 2019 18:43:22 +0000 (12:43 -0600)
committerVinod Koul <vkoul@kernel.org>
Mon, 7 Jan 2019 12:35:22 +0000 (18:05 +0530)
commit55f53b9c1746bba0e1b3a8d82ff3abe7ad3b96ce
tree2055b0e27f4b86659caac4b4a579114d62f1b096
parented414d580310c3ec95abcef508035040e21a629d
dmaengine: st_fdma: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/st_fdma.c