]> asedeno.scripts.mit.edu Git - linux.git/commit
opp: Don't use IS_ERR on invalid supplies
authorDmitry Osipenko <digetx@gmail.com>
Sun, 23 Jun 2019 17:50:53 +0000 (20:50 +0300)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 24 Jun 2019 07:18:29 +0000 (12:48 +0530)
commit560d1bcad715c215e7ffe5d7cffe045974b623d0
tree39b37ff7641b9e322a61817da99df4b9efaf5645
parentcd7ea582866f43324f3d60f0d4daac05e08f0f41
opp: Don't use IS_ERR on invalid supplies

_set_opp_custom() receives a set of OPP supplies as its arguments and
the caller of it passes NULL when the supplies are not valid. But
_set_opp_custom(), by mistake, checks for error by performing
IS_ERR(old_supply) on it which will always evaluate to false.

The problem was spotted during of testing of upcoming update for the
NVIDIA Tegra CPUFreq driver.

Cc: stable <stable@vger.kernel.org>
Fixes: 7e535993fa4f ("OPP: Separate out custom OPP handler specific code")
Reported-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
[ Viresh: Massaged changelog ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/core.c