]> asedeno.scripts.mit.edu Git - linux.git/commit
ARM: 8579/1: mm: Fix definition of pmd_mknotpresent
authorSteve Capper <steve.capper@arm.com>
Tue, 7 Jun 2016 16:58:06 +0000 (17:58 +0100)
committerRussell King <rmk+kernel@armlinux.org.uk>
Thu, 9 Jun 2016 16:51:47 +0000 (17:51 +0100)
commit56530f5d2ddc9b9fade7ef8db9cb886e9dc689b5
treef9386825ee9feadc54787360aafb744d78bc9ed5
parent624531886987f0f1b5d01fb598034d039198e090
ARM: 8579/1: mm: Fix definition of pmd_mknotpresent

Currently pmd_mknotpresent will use a zero entry to respresent an
invalidated pmd.

Unfortunately this definition clashes with pmd_none, thus it is
possible for a race condition to occur if zap_pmd_range sees pmd_none
whilst __split_huge_pmd_locked is running too with pmdp_invalidate
just called.

This patch fixes the race condition by modifying pmd_mknotpresent to
create non-zero faulting entries (as is done in other architectures),
removing the ambiguity with pmd_none.

[catalin.marinas@arm.com: using L_PMD_SECT_VALID instead of PMD_TYPE_SECT]

Fixes: 8d9625070073 ("ARM: mm: Transparent huge page support for LPAE systems.")
Cc: <stable@vger.kernel.org> # 3.11+
Reported-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Steve Capper <steve.capper@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/include/asm/pgtable-3level.h