]> asedeno.scripts.mit.edu Git - linux.git/commit
mac80211: ethtool: avoid 32 bit multiplication overflow
authorColin Ian King <colin.king@canonical.com>
Tue, 8 May 2018 12:57:32 +0000 (13:57 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 8 May 2018 13:02:03 +0000 (15:02 +0200)
commit57c6cb81717f957fb741f2e4c79bd0e2f4f55910
treed83d668ee4b94418145a9c92855f78a916f1e718
parent2fe4a29a452a68ffa8a501000d0ef8095c242eba
mac80211: ethtool: avoid 32 bit multiplication overflow

The multiplication of 100000 * cfg80211_calculate_bitrate() is a 32 bit
operation and can overflow if cfg80211_calculate_bitrate is greater
than 42949. Although I don't believe this is occurring at present, it
would be safer to avoid the potential overflow by making the constant
100000 an ULL to ensure a 64 multiplication occurs.

Detected by CoverityScan, CID#1468643 ("Unintentional integer overflow")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/ethtool.c