]> asedeno.scripts.mit.edu Git - linux.git/commit
pinctrl: intel: Allocate IRQ chip dynamic
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 16 Sep 2019 14:47:51 +0000 (17:47 +0300)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Tue, 1 Oct 2019 14:36:07 +0000 (17:36 +0300)
commit57ff2df1b952c7934d7b0e1d3a2ec403ec76edec
treefa65ed1820f442551e5e03e216b9f0566e0d577d
parent54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c
pinctrl: intel: Allocate IRQ chip dynamic

Keeping the IRQ chip definition static shares it with multiple instances of
the GPIO chip in the system. This is bad and now we get this warning from
GPIO library:

"detected irqchip that is shared with multiple gpiochips: please fix the driver."

Hence, move the IRQ chip definition from being driver static into the struct
intel_pinctrl. So a unique IRQ chip is used for each GPIO chip instance.

Fixes: ee1a6ca43dba ("pinctrl: intel: Add Intel Broxton pin controller support")
Depends-on: 5ff56b015e85 ("pinctrl: intel: Disable GPIO pin interrupts in suspend")
Reported-by: Federico Ricchiuto <fed.ricchiuto@gmail.com>
Suggested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/pinctrl/intel/pinctrl-intel.c