]> asedeno.scripts.mit.edu Git - linux.git/commit
powerpc/perf: Fix oops when grouping different pmu events
authorRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Thu, 30 Nov 2017 08:33:22 +0000 (14:03 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 4 Dec 2017 05:03:19 +0000 (16:03 +1100)
commit5aa04b3eb6fca63d2e9827be656dcadc26d54e11
treeb07e919885c34c47cc2c7b644422a0291922d4ac
parentae64f9bd1d3621b5e60d7363bc20afb46aede215
powerpc/perf: Fix oops when grouping different pmu events

When user tries to group imc (In-Memory Collections) event with
normal event, (sometime) kernel crashes with following log:

    Faulting instruction address: 0x00000000
    [link register   ] c00000000010ce88 power_check_constraints+0x128/0x980
    ...
    c00000000010e238 power_pmu_event_init+0x268/0x6f0
    c0000000002dc60c perf_try_init_event+0xdc/0x1a0
    c0000000002dce88 perf_event_alloc+0x7b8/0xac0
    c0000000002e92e0 SyS_perf_event_open+0x530/0xda0
    c00000000000b004 system_call+0x38/0xe0

'event_base' field of 'struct hw_perf_event' is used as flags for
normal hw events and used as memory address for imc events. While
grouping these two types of events, collect_events() tries to
interpret imc 'event_base' as a flag, which causes a corruption
resulting in a crash.

Consider only those events which belongs to 'perf_hw_context' in
collect_events().

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Reviewed-By: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/perf/core-book3s.c