]> asedeno.scripts.mit.edu Git - linux.git/commit
crypto: ghash - fix unaligned memory access in ghash_setkey()
authorEric Biggers <ebiggers@google.com>
Thu, 30 May 2019 17:50:39 +0000 (10:50 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 6 Jun 2019 06:38:57 +0000 (14:38 +0800)
commit5c6bc4dfa515738149998bb0db2481a4fdead979
tree4e5e9129c4eb8fcc6dc9329ccaaa9dd6a7f6dd58
parent67882e76492483bafa9b1b1648bb031e9abe5185
crypto: ghash - fix unaligned memory access in ghash_setkey()

Changing ghash_mod_init() to be subsys_initcall made it start running
before the alignment fault handler has been installed on ARM.  In kernel
builds where the keys in the ghash test vectors happened to be
misaligned in the kernel image, this exposed the longstanding bug that
ghash_setkey() is incorrectly casting the key buffer (which can have any
alignment) to be128 for passing to gf128mul_init_4k_lle().

Fix this by memcpy()ing the key to a temporary buffer.

Don't fix it by setting an alignmask on the algorithm instead because
that would unnecessarily force alignment of the data too.

Fixes: 2cdc6899a88e ("crypto: ghash - Add GHASH digest algorithm for GCM")
Reported-by: Peter Robinson <pbrobinson@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/ghash-generic.c