]> asedeno.scripts.mit.edu Git - linux.git/commit
leds: trigger: netdev: fix handling on interface rename
authorMartin Schiller <ms@dev.tdt.de>
Fri, 25 Oct 2019 07:01:42 +0000 (09:01 +0200)
committerPavel Machek <pavel@ucw.cz>
Sun, 3 Nov 2019 17:10:12 +0000 (18:10 +0100)
commit5f820ed52371b4f5d8c43c93f03408d0dbc01e5b
tree94a1154c9fb7557c2cfb3527f76b22b9da01f78e
parentfc7b5028f2627133c7c18734715a08829eab4d1f
leds: trigger: netdev: fix handling on interface rename

The NETDEV_CHANGENAME code is not "unneeded" like it is stated in commit
4cb6560514fa ("leds: trigger: netdev: fix refcnt leak on interface
rename").

The event was accidentally misinterpreted equivalent to
NETDEV_UNREGISTER, but should be equivalent to NETDEV_REGISTER.

This was the case in the original code from the openwrt project.

Otherwise, you are unable to set netdev led triggers for (non-existent)
netdevices, which has to be renamed. This is the case, for example, for
ppp interfaces in openwrt.

Fixes: 06f502f57d0d ("leds: trigger: Introduce a NETDEV trigger")
Fixes: 4cb6560514fa ("leds: trigger: netdev: fix refcnt leak on interface rename")
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/trigger/ledtrig-netdev.c