]> asedeno.scripts.mit.edu Git - linux.git/commit
powerpc/papr_scm: Fix an off-by-one check in papr_scm_meta_{get, set}
authorVaibhav Jain <vaibhav@linux.ibm.com>
Fri, 27 Sep 2019 06:20:02 +0000 (11:50 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 10 Oct 2019 09:15:53 +0000 (20:15 +1100)
commit612ee81b9461475b5a5612c2e8d71559dd3c7920
tree36eeb3aeaaa1b767b2fe786d0b8b1dc74591d509
parentda0c9ea146cbe92b832f1b0f694840ea8eb33cce
powerpc/papr_scm: Fix an off-by-one check in papr_scm_meta_{get, set}

A validation check to prevent out of bounds read/write inside
functions papr_scm_meta_{get,set}() is off-by-one that prevent reads
and writes to the last byte of the label area.

This bug manifests as a failure to probe a dimm when libnvdimm is
unable to read the entire config-area as advertised by
ND_CMD_GET_CONFIG_SIZE. This usually happens when there are large
number of namespaces created in the region backed by the dimm and the
label-index spans max possible config-area. An error of the form below
usually reported in the kernel logs:

[  255.293912] nvdimm: probe of nmem0 failed with error -22

The patch fixes these validation checks there by letting libnvdimm
access the entire config-area.

Fixes: 53e80bd042773('powerpc/nvdimm: Add support for multibyte read/write for metadata')
Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190927062002.3169-1-vaibhav@linux.ibm.com
arch/powerpc/platforms/pseries/papr_scm.c