]> asedeno.scripts.mit.edu Git - linux.git/commit
powerpc/tm: Don't check for WARN in TM Bad Thing handling
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 12 Oct 2017 04:45:25 +0000 (15:45 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 6 Nov 2017 05:48:16 +0000 (16:48 +1100)
commit632f0574167ad3f5d646dad6af87d976a703d93e
tree172d2f41a19fdefc1d9c80f6a015d4dc8547a30e
parent1fd6c02207107c8892219dacef01de7ced3d4ce7
powerpc/tm: Don't check for WARN in TM Bad Thing handling

Currently when we take a TM Bad Thing program check exception, we
search the bug table to see if the program check was generated by a
WARN/WARN_ON etc.

That makes no sense, the WARN macros use trap instructions, which
should never generate a TM Bad Thing exception. If they ever did that
would be a bug and we should oops.

We do have some hand-coded bugs in tm.S, using EMIT_BUG_ENTRY, but
those are all BUGs not WARNs, and they all use trap instructions
anyway. Almost certainly this check was incorrectly copied from the
REASON_TRAP handling in the same function.

Remove it.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-By: Michael Neuling <mikey@neuling.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/traps.c