]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/vkms: provide a parent device to drm_dev_init()
authorEmil Velikov <emil.velikov@collabora.com>
Fri, 26 Oct 2018 10:05:50 +0000 (11:05 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Mon, 29 Oct 2018 11:13:40 +0000 (11:13 +0000)
commit633873e6cb884f903468f81f2e8df8975877fadd
treeae6a5e2c28c5134d370eca5535a19174ea553670
parent47164e0b0df88494235e6416a68ffcb993503b8d
drm/vkms: provide a parent device to drm_dev_init()

Earlier commit updated the vgem driver to improve the topology, by
passing a platform device as parent to drm_dev_init(). Shortly
afterwords we updated the core function to BUG() in order to catch any
buggy drivers passing NULL as parent.

While I missed the vkms driver (as the patch predates vkms by a few
months), the BUG caught the issue within couple of hours.

Swap the drm_dev_init <> platform_device_register_simple order, to
the driver back to life.

Fixes: f08877e79485 ("drm: BUG_ON if passing NULL parent to drm_dev_init")
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Deepak Sharma <deepak.sharma@amd.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20181026100550.625-1-emil.l.velikov@gmail.com
drivers/gpu/drm/vkms/vkms_drv.c