]> asedeno.scripts.mit.edu Git - linux.git/commit
media: vsp1: Fix BRx conditional path in WPF
authorKieran Bingham <kieran.bingham@ideasonboard.com>
Mon, 26 Mar 2018 13:29:17 +0000 (09:29 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 4 Apr 2018 10:27:28 +0000 (06:27 -0400)
commit639fa43d59e5a41ca8c55592cd5c1021fea2ab83
treeacd4968cfda7204acfb247142b718aa9af951175
parent19ad26f9e6e1decdde6d48fe1849a06a103b0f09
media: vsp1: Fix BRx conditional path in WPF

When a BRx is provided by a pipeline, the WPF must determine the master
layer. Currently the condition to check this identifies pipe->bru ||
pipe->num_inputs > 1.

The code then moves on to dereference pipe->bru, thus the check fails
static analysers on the possibility that pipe->num_inputs could be
greater than 1 without pipe->bru being set.

The reality is that the pipeline must have a BRx to support more than
one input, thus this could never cause a fault - however it also
identifies that the num_inputs > 1 check is redundant.

Remove the redundant check - and always configure the master layer
appropriately when we have a BRx configured in our pipeline.

Fixes: 6134148f6098 ("v4l: vsp1: Add support for the BRS entity")
Cc: stable@vger.kernel.org
Suggested-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/vsp1/vsp1_wpf.c