]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: mediatek: mt8183: move card registration to the end of probe
authorTzung-Bi Shih <tzungbi@google.com>
Wed, 22 May 2019 14:54:02 +0000 (22:54 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 23 May 2019 13:34:43 +0000 (14:34 +0100)
commit63ba8e4d04ab921f8aaa89227d2e0f7ad79725be
treefa9bc1423c79f03b9bdd54a8823c16674bd37546
parent108d0d40b932f80fc7f1dbd1de548d666e649a4b
ASoC: mediatek: mt8183: move card registration to the end of probe

mt8183_mt6358_ts3a227_max98357_dev_probe() does not return immediately
if devm_snd_soc_register_card() returns fail.  As a result, the rest of
code still get executed.

Two options to fix:
1. add an extra return statement if devm_snd_soc_register_card()
   returns fail
2. move devm_snd_soc_register_card() to the end of probe

Adopt option 2 which is more clear and common.

Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c