]> asedeno.scripts.mit.edu Git - linux.git/commit
pinctrl: freescale: mxs: Add of_node_put() before return
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Sun, 4 Aug 2019 16:04:20 +0000 (21:34 +0530)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 6 Aug 2019 12:52:24 +0000 (14:52 +0200)
commit646d90c3c2c19dcc85b3d1c7c43a26e900d4074f
treee16b5272da1da76ab39a383a771814a0b2228528
parentf452444709c07ea5d126e9f312f602ac9c5e34fd
pinctrl: freescale: mxs: Add of_node_put() before return

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
three places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804160420.5309-1-nishkadg.linux@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/freescale/pinctrl-mxs.c