]> asedeno.scripts.mit.edu Git - linux.git/commit
btrfs: drop the lock on error in btrfs_dev_replace_cancel
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 11 Feb 2019 18:32:10 +0000 (21:32 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 25 Feb 2019 13:13:41 +0000 (14:13 +0100)
commit669e859b5ea7c6f4fce0149d3907c64e550c294b
tree924066e3cd8358f345bebb385d037ff178cdd423
parent349ae63f40638a28c6fce52e8447c2d14b84cc0c
btrfs: drop the lock on error in btrfs_dev_replace_cancel

We should drop the lock on this error path.  This has been found by a
static tool.

The lock needs to be released, it's there to protect access to the
dev_replace members and is not supposed to be left locked. The value of
state that's being switched would need to be artifically changed to an
invalid value so the default: branch is taken.

Fixes: d189dd70e255 ("btrfs: fix use-after-free due to race between replace start and cancel")
CC: stable@vger.kernel.org # 5.0+
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/dev-replace.c