]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/sti: do not remove the drm_bridge that was never added
authorPeter Rosin <peda@axentia.se>
Mon, 6 Aug 2018 06:19:09 +0000 (08:19 +0200)
committerBenjamin Gaignard <benjamin.gaignard@linaro.org>
Tue, 7 Aug 2018 13:33:00 +0000 (15:33 +0200)
commit66e31a72dc38543b2d9d1ce267dc78ba9beebcfd
tree5c458116689572faf1b9fcfeaf5e04955d4d350b
parent161ad653d6c9ca2c5ef3bc4fc883689932c9ac8e
drm/sti: do not remove the drm_bridge that was never added

Removing the drm_bridge_remove call should avoid a NULL dereference
during list processing in drm_bridge_remove if the error path is ever
taken.

The more natural approach would perhaps be to add a drm_bridge_add,
but there are several other bridges that never call drm_bridge_add.
Just removing the drm_bridge_remove is the easier fix.

Fixes: 84601dbdea36 ("drm: sti: rework init sequence")
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20180806061910.29914-2-peda@axentia.se
drivers/gpu/drm/sti/sti_hda.c
drivers/gpu/drm/sti/sti_hdmi.c