]> asedeno.scripts.mit.edu Git - linux.git/commit
vhost: fix info leak due to uninitialized memory
authorMichael S. Tsirkin <mst@redhat.com>
Fri, 11 May 2018 21:33:10 +0000 (00:33 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 12 Jun 2018 01:59:29 +0000 (04:59 +0300)
commit670ae9caaca467ea1bfd325cb2a5c98ba87f94ad
treefa217f1338634e7f9d0955193d66445cd78740a6
parent55e49dc43a835b19567e62142cb1c87dc7db7b3c
vhost: fix info leak due to uninitialized memory

struct vhost_msg within struct vhost_msg_node is copied to userspace.
Unfortunately it turns out on 64 bit systems vhost_msg has padding after
type which gcc doesn't initialize, leaking 4 uninitialized bytes to
userspace.

This padding also unfortunately means 32 bit users of this interface are
broken on a 64 bit kernel which will need to be fixed separately.

Fixes: CVE-2018-1118
Cc: stable@vger.kernel.org
Reported-by: Kevin Easton <kevin@guarana.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: syzbot+87cfa083e727a224754b@syzkaller.appspotmail.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/vhost/vhost.c