]> asedeno.scripts.mit.edu Git - linux.git/commit
rtc: opal: Fix OPAL RTC driver OPAL_BUSY loops
authorNicholas Piggin <npiggin@gmail.com>
Tue, 10 Apr 2018 11:49:32 +0000 (21:49 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 25 Apr 2018 03:24:13 +0000 (13:24 +1000)
commit682e6b4da5cbe8e9a53f979a58c2a9d7dc997175
tree25b4eb837ae2f09cfd0ba5a54dc975fa0cfcaa92
parent75ecfb49516c53da00c57b9efe48fa3f5504a791
rtc: opal: Fix OPAL RTC driver OPAL_BUSY loops

The OPAL RTC driver does not sleep in case it gets OPAL_BUSY or
OPAL_BUSY_EVENT from firmware, which causes large scheduling
latencies, up to 50 seconds have been observed here when RTC stops
responding (BMC reboot can do it).

Fix this by converting it to the standard form OPAL_BUSY loop that
sleeps.

Fixes: 628daa8d5abf ("powerpc/powernv: Add RTC and NVRAM support plus RTAS fallbacks")
Cc: stable@vger.kernel.org # v3.2+
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/powernv/opal-rtc.c
drivers/rtc/rtc-opal.c