]> asedeno.scripts.mit.edu Git - linux.git/commit
platform/x86: GPD pocket fan: Use default values when wrong modparams are given
authorHans de Goede <hdegoede@redhat.com>
Mon, 6 Jan 2020 14:42:18 +0000 (15:42 +0100)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 13 Jan 2020 09:37:50 +0000 (11:37 +0200)
commit6ae01050e49f0080ae30575d9b45a6d4a3d7ee23
tree6f54e287c71f316f473390e7b48bad8a95a5c51f
parent638bc4ca3d28c25986cce4cbad69d9b8abf1e434
platform/x86: GPD pocket fan: Use default values when wrong modparams are given

Use our default values when wrong module-parameters are given, instead of
refusing to load. Refusing to load leaves the fan at the BIOS default
setting, which is "Off". The CPU's thermal throttling should protect the
system from damage, but not-loading is really not the best fallback in this
case.

This commit fixes this by re-setting module-parameter values to their
defaults if they are out of range, instead of failing the probe with
-EINVAL.

Cc: stable@vger.kernel.org
Cc: Jason Anderson <jasona.594@gmail.com>
Reported-by: Jason Anderson <jasona.594@gmail.com>
Fixes: 594ce6db326e ("platform/x86: GPD pocket fan: Use a min-speed of 2 while charging")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/gpd-pocket-fan.c