]> asedeno.scripts.mit.edu Git - linux.git/commit
net: fddi: skfp: Remove unused function
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 20 Sep 2018 22:36:33 +0000 (15:36 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Sep 2018 02:05:06 +0000 (19:05 -0700)
commit6b8e327cfa2dfb9da2bd70326494a1f5ca9968f7
tree89ea6871fd5fd98f478c2ff253bd2f8f4e0a72c9
parent83b4768e1b6bd92a94b15ccb22762c686f5ede38
net: fddi: skfp: Remove unused function

Clang warns when a variable is assigned to itself.

drivers/net/fddi/skfp/pcmplc.c:1257:6: warning: explicitly assigning
value of variable of type 'int' to itself [-Wself-assign]
        phy = phy ; on_off = on_off ;
        ~~~ ^ ~~~
drivers/net/fddi/skfp/pcmplc.c:1257:21: warning: explicitly assigning
value of variable of type 'int' to itself [-Wself-assign]
        phy = phy ; on_off = on_off ;
                    ~~~~~~ ^ ~~~~~~
2 warnings generated.

Turns out this entire function doesn't actually do anything since
SK_UNUSED is just casting the pointer to void. Remove it to silence
this Clang warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/128
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/fddi/skfp/ecm.c
drivers/net/fddi/skfp/h/cmtdef.h
drivers/net/fddi/skfp/pcmplc.c