]> asedeno.scripts.mit.edu Git - linux.git/commit
btrfs: shut up bogus -Wmaybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 17 Jun 2019 11:07:28 +0000 (13:07 +0200)
committerDavid Sterba <dsterba@suse.com>
Tue, 2 Jul 2019 10:30:49 +0000 (12:30 +0200)
commit6c64460cdc8be5fa074aa8fe2ae8736d5792bdc5
tree8bb242da4125bce1d017f6045d60e608e2c62c15
parent9e967495e0e0ae8bb08f52aa71b29affc7075d31
btrfs: shut up bogus -Wmaybe-uninitialized warning

gcc sometimes can't determine whether a variable has been initialized
when both the initialization and the use are conditional:

fs/btrfs/props.c: In function 'inherit_props':
fs/btrfs/props.c:389:4: error: 'num_bytes' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    btrfs_block_rsv_release(fs_info, trans->block_rsv,

This code is fine. Unfortunately, I cannot think of a good way to
rephrase it in a way that makes gcc understand this, so I add a bogus
initialization the way one should not.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: David Sterba <dsterba@suse.com>
[ gcc 8 and 9 don't emit the warning ]
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/props.c