]> asedeno.scripts.mit.edu Git - linux.git/commit
svcrdma: Clean up svc_rdma_build_read_chunk()
authorChuck Lever <chuck.lever@oracle.com>
Tue, 1 Aug 2017 16:00:14 +0000 (12:00 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 25 Aug 2017 02:13:50 +0000 (22:13 -0400)
commit7075a867ce5748007b299bd28f12754cd51719d4
treeb009fd5045e9ff602bb1682944b2e053ea23e37b
parentafea5657c20b11ec9f895ac5cc33b560fb1e0276
svcrdma: Clean up svc_rdma_build_read_chunk()

Dan Carpenter <dan.carpenter@oracle.com> observed that the while()
loop in svc_rdma_build_read_chunk() does not document the assumption
that the loop interior is always executed at least once.

Defensive: the function now returns -EINVAL if this assumption
fails.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/xprtrdma/svc_rdma_rw.c