]> asedeno.scripts.mit.edu Git - linux.git/commit
media: rc: nuvoton: Tweak the interrupt enabling dance
authorMichał Winiarski <michal.winiarski@intel.com>
Mon, 21 May 2018 14:38:01 +0000 (10:38 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 28 May 2018 21:36:31 +0000 (17:36 -0400)
commit70c30b1ea706affcb117e3cd3065690abca5ba69
treecd552d81c87b98c0aa746de9406c1cc652a68dc2
parentf620d1d7afc7db57ab59f35000752840c91f67e7
media: rc: nuvoton: Tweak the interrupt enabling dance

It appears that we need to enable CIR device before attempting to touch
some of the registers. Previously, this was not a big issue, since we
were rarely seeing nvt_close() getting called.

Unfortunately, since commit cb84343fced1 ("media: lirc: do not call close()
or open() on unregistered devices") the initial open() during probe from
rc_setup_rx_device() is no longer successful, which means that userspace
clients will actually end up calling nvt_open()/nvt_close(). Since
nvt_open() is broken, the device doesn't seem to work as expected.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199597

Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Cc: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/rc/nuvoton-cir.c