]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amd/powerplay: wrong control mode cause the fan spins faster unnecessarily
authorEvan Quan <evan.quan@amd.com>
Wed, 1 Nov 2017 08:52:08 +0000 (16:52 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 2 Nov 2017 03:31:13 +0000 (23:31 -0400)
commit710931c2be5a784c0651111f54bd083e3681c309
tree8cac23c9eb0724550e44ac5cdf67ff5bae758b02
parent7b38a49d75fb5e90512e63038449222c2ef651ef
drm/amd/powerplay: wrong control mode cause the fan spins faster unnecessarily

The fan control mode can either be FDO_PWM_MODE_STATIC or FDO_PWM_MODE_STATIC_RPM.
Setting it as AMD_FAN_CTRL_AUTO will cause the fan spin faster wrongly.

This can be reproduced by:
'# cat /sys/class/hwmon/hwmon0/pwm1
   38
'# cat /sys/class/hwmon/hwmon0/pwm1_enable
   2
'# echo "2" > /sys/class/hwmon/hwmon0/pwm1_enable
'# cat /sys/class/hwmon/hwmon0/pwm1
   122
The fan speed get faster wrongly even with its original mode echo back.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c