]> asedeno.scripts.mit.edu Git - linux.git/commit
pinctrl: actions: Fix uninitialized error in owl_pin_config_set()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Fri, 8 Jun 2018 10:05:47 +0000 (12:05 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 18 Jun 2018 05:55:56 +0000 (07:55 +0200)
commit71fd5d07b791b90587f695f048ad82e8d4c1c67e
tree130037e0c17deac5a795181ae8f5efc204ffa9b3
parent7f57871f39912978e95db920ddbbfb2304a4bfbf
pinctrl: actions: Fix uninitialized error in owl_pin_config_set()

With gcc 4.1.2:

    drivers/pinctrl/actions/pinctrl-owl.c: In function ‘owl_pin_config_set’:
    drivers/pinctrl/actions/pinctrl-owl.c:336: warning: ‘ret’ may be used uninitialized in this function

Indeed, if num_configs is zero, the uninitialized value will be returned
as an error code.

Fix this by preinitializing it to zero.

Fixes: 2242ddfbf4d699b5 ("pinctrl: actions: Add Actions S900 pinctrl driver")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/actions/pinctrl-owl.c